mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-15 21:29:58 -04:00
A stack overflow leaves the faulting thread only a guard page's worth of stack for the handler, and the crash report needs more: main.c crash_handler's rt_log buffers are 2 KiB each, it walks the frames, and while the boot builds pipelines its first call writes a file (plat_file_write's frame is about 4 KiB). Nothing in the runtime set a stack guarantee, so the report faulted again; the verifier's probe ended with 0xC0000005 and no line once the report's first call was the file write. The launcher starts the game with stderr on DEVNULL, so raw_note's stderr line was all there was, and nobody saw it. The new platform plat_stack_guarantee calls SetThreadStackGuarantee with PLAT_STACK_GUARANTEE (32 KiB) and runs at the start of every thread win32.c thread_main starts, in fiber_start (a guest fiber's stack is its own and the guarantee belongs to the running fiber), and on the main thread in main. Each thread and fiber commits that much more of its stack. Linux's crash handling already runs on its signal stack (linux.c alt_stack), so it is empty there. Reproduced before the change by the new tests/crash_stack_check.py: a plat_thread_spawn thread and a plat_fiber_new fiber recurse until their stacks run out, and the handler writes a file and three 2 KiB log lines. Without the guarantee both ended with 0xC0000005 and no line; with it both write every line and end with 71. thread_end_check, fatal_exit_check and the compile checks pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
69 lines
2.8 KiB
Python
69 lines
2.8 KiB
Python
"""Build and run tests/crash_stack_check.c: a stack overflow on a thread and on a fiber made by the platform layer
|
|
(runtime/platform/win32.c thread_main, fiber_start, plat_stack_guarantee) still gets its whole crash report, a file
|
|
write and three 2 KiB log lines, and ends with the report's code 71. Without the stack kept back the report faulted
|
|
again and the process ended with an access violation and no line. No game files.
|
|
|
|
Usage: crash_stack_check.py
|
|
"""
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
MSYS_BIN = Path(r'C:\msys64\ucrt64\bin')
|
|
|
|
LAYOUT = '''// A stand-in for the generated layout.h (tests/crash_stack_check.py).
|
|
#pragma once
|
|
#define MOD_MAIN_BASE 0x7000000000ull
|
|
#define MOD_MAIN_SIZE 0x4ea0000ull
|
|
'''
|
|
|
|
|
|
def compiler():
|
|
if os.environ.get('CC'):
|
|
return os.environ['CC']
|
|
if os.name == 'nt' and (MSYS_BIN / 'clang.exe').exists():
|
|
return str(MSYS_BIN / 'clang.exe')
|
|
return shutil.which('clang') or 'clang'
|
|
|
|
|
|
def main():
|
|
if os.name != 'nt':
|
|
print('crash_stack_check: Windows only')
|
|
return 0
|
|
work = ROOT / 'build' / 'test' / 'crash_stack'
|
|
work.mkdir(parents=True, exist_ok=True)
|
|
(work / 'layout.h').write_text(LAYOUT)
|
|
exe = work / 'crash_stack_check.exe'
|
|
env = dict(os.environ)
|
|
if MSYS_BIN.exists():
|
|
env['PATH'] = str(MSYS_BIN) + os.pathsep + env.get('PATH', '')
|
|
rt = ROOT / 'runtime'
|
|
plat = [rt / 'platform' / 'win32.c', rt / 'platform' / 'common.c']
|
|
libs = ['-lbcrypt', '-lws2_32', '-lpsapi', '-lwinmm', '-ldbghelp', '-lshell32', '-lole32', '-luser32', '-ladvapi32']
|
|
subprocess.check_call([compiler(), '-O1', '-g', '-Wall', '-Wno-unused-function', '-fno-strict-aliasing',
|
|
'-march=x86-64-v3', '-I', str(rt), '-I', str(work), str(ROOT / 'tests' / 'crash_stack_check.c'),
|
|
*map(str, plat), '-o', str(exe), '-lm', *libs], env=env)
|
|
bad = 0
|
|
for mode in ('thread', 'fiber'):
|
|
note = work / f'note_{mode}.txt'
|
|
note.unlink(missing_ok=True)
|
|
p = subprocess.run([str(exe), mode, str(note)], env=env, capture_output=True, text=True, errors='replace',
|
|
timeout=60)
|
|
lines = [f'report line {i}' for i in (1, 2, 3)]
|
|
missing = [x for x in lines if x not in p.stdout]
|
|
ok = p.returncode == 71 and not missing and 'stack overflow' in p.stdout and 'the file written: 1' in p.stdout
|
|
print(f'a stack overflow on a {mode}: exit code {p.returncode & 0xffffffff:#x} (want 0x47), '
|
|
f'{3 - len(missing)} of 3 report lines: {"ok" if ok else "FAIL"}', flush=True)
|
|
if not ok:
|
|
print(p.stdout[-2000:], p.stderr[-2000:])
|
|
bad += not ok
|
|
print(f'crash_stack_check: {"FAILED" if bad else "ok"}')
|
|
return 1 if bad else 0
|
|
|
|
|
|
if __name__ == '__main__':
|
|
sys.exit(main())
|