mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-16 11:49:59 -04:00
The review found that the comments on frz_lock (memory.c, above FRZ_SHIFT), lazy_fly_run and vk_memory.c lazy_fetch said a fetch runs under frz_lock only in a mapping change's thaw or with NX2NAVI_WB_LAZY_UNLOCKED=0. In fact thaw_begin_locked's lazy_drop_region_locked runs in every thaw under the lock: a mapping change, the lazy heap's commit, and thaw_fault on a write lazy_fault did not take. lazy_drop_region_locked's own comment said "a write fault in a frozen region", but a frozen region holds no armed ranges. And the LZ_SLOTS comment called four slots more than the threads that touch armed pages together, where the reference session had six such threads and the flight table holds 64. The comments now give that list of thaws, and LZ_SLOTS says that fetches past it wait 20 us at a time for a slot. Comments only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
113 KiB
113 KiB