mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-17 04:59:57 -04:00
mirror_create put the pool on mlist under pool_lock, released the lock, and only then set acc_sub, mstate = MS_ON, asked_room and twin. It also took pool_lock again for the device address table's hand-over (gpa_flip) or, with NX2NAVI_GPA_LATE=0, the remap. pool_fini calls mirror_forget only when it finds MS_ON. A finalize on another thread in that gap therefore left the record on mlist, and destroy_rec freed it and its buffer without taking it off the list. The next hot_check, mirror_evict, vk_mem_mirror_begin or gpa_flip_cmds then read freed memory, and mirror_evict could defer the freed buffer a second time. With GPA_LATE=0, the table record then named the destroyed buffer. Now one hold covers the finalize check, the insertion, acc_sub then MS_ON, asked_room, twin, and the hand-over or remap. twin_wanted and gpa_late are decided before the lock is taken, since each may read its setting and log once. The untwinned counters are atomics and stay after the hold. Not reproduced before the change: no check without a device can drive the race. Checks that passed: pass_cc_check on vk_memory.c, no new -Wall -Wextra warnings, wb_lazy_check, gpa_check, mem_growth_check, mem_budget_check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
350 KiB
350 KiB