mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-16 01:49:58 -04:00
With NX2NAVI_WB_LAZY_CHUNK=1 (off by default), lazy_fault's piece branch called lazy_piece_locked with lz_lock held. lazy_piece_locked fetched the piece (vk_memory.c lazy_fetch: a submit under the queue lock, then a fence wait of up to 10 s) and made its pages read-write, all under lz_lock. memory.c's own rule says lz_lock is never held across a system call or a fetch. The replay asks that lock at every draw that writes a mirrored pool (mem_lazy_skip) and at the end of every part (mem_lazy_window, mem_lazy_armed), so it waited for the whole fetch. lazy_piece_locked is split in two. lazy_piece_take_locked runs with lz_lock held: the piece leaves the list and the segment's rest on either side goes back. lazy_piece_fetch_locked runs with frz_lock only: the fetch, the page calls, the region flags and the hold. lazy_fault calls the first, drops lz_lock, then calls the second, as its whole-segment branch does. A second fault on the same piece waits for frz_lock, finds no segment once the fetch and the reprotect are done, and access_fault retries the access, as with the segment path. Not reproduced before the change: chunk mode is off by default and no check without a device covers the fetch. Checks that passed: pass_cc_check on memory.c, no new -Wall -Wextra warnings, wb_lazy_check, heap_lazy_copy_check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
98 KiB
98 KiB