mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-16 15:59:59 -04:00
The review of d2014496 found that vk_frame_hold_left loaded left_ns, last_ns and holding as three separate relaxed loads while frame_hold_refill could store between them, so a reader on a replaying thread could pair a new left_ns with an old last_ns and count one present interval twice (or, the other way round, not at all) for its decision, the effect d2014496 meant to remove, now on the read side only; its comment presented the read as exact. Now frame_hold_refill writes the pair between two steps of FH.seq (odd while it writes), and vk_frame_hold_left reads it again when a read overlapped a refill. After FH_READ_TRIES such reads it goes with the last one, as vk_evo_peek.h does, so a drawing thread never waits for the present; the comment says what such a read can get wrong. holding is still stored after the refill, and a read between the two applies the previous frame's value to the microseconds since that refill, which the comment says too. The decision is asked only for a full-screen draw whose pipeline is still pending (vk_exec_draw.c). Not reproduced before the change. Checks that passed: pass_cc_check of vk_backend.c with no new -Wall -Wextra warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
64 KiB
64 KiB