Name Vulkan layers called VkLayer_*, a recorder's Vulkan hook and a driver's capture tool as foreign in the crash report.

main.c foreign_hook matched "vk_layer", "hook", "overlay" and "reshade" in the lower-cased module name, so a crash
inside a layer named in the usual VkLayer_<name>.dll way (lower-cased "vklayer_") or inside obs-vulkan64.dll or
nvspcap64.dll lacked the line that the module is not part of the game (the audit's probe on these names).

It also matches "vklayer", "obs-vulkan" and "nvspcap" now, and leaves out "vklayer_khronos": the validation layer is
one the game loads itself when NX2NAVI_VK_VALIDATION asks, and its crash should not tell a developer to close a
recording program. Crash text only.

Reproduced before the change from the probe's names; the new tests/foreign_hook_check.py cuts foreign_hook out of
main.c and checks nine foreign names and ten of the game's own and the drivers' (the validation layer among them).
It and the compile checks pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
chrg6
2026-11-13 17:45:19 -05:00
parent 0efa9a4c78
commit 4a36e96411
2 changed files with 78 additions and 2 deletions

View File

@@ -318,13 +318,17 @@ static int readable(uint64_t a, uint64_t n) { return plat_mem_readable(a, n); }
// capture tool or a post-processing injector, by the words such files carry in their names. A crash inside one is that
// program's: one report was an access violation in a recorder's layer the moment the present mode changed and the
// swapchain was made again, another an injector's layer reading a null pointer at the end of every shader
// preparation.
// preparation. Vulkan layers are mostly named VkLayer_<name>.dll, and a recorder's Vulkan hook and a driver's capture
// tool carry names of their own (the words below). The validation layer is left out: the game loads it itself when
// NX2NAVI_VK_VALIDATION asks.
static int foreign_hook(const char *module) {
char low[160];
size_t n = 0;
for (; module && module[n] && n < sizeof low - 1; n++) low[n] = (char)tolower((unsigned char)module[n]);
low[n] = 0;
return strstr(low, "vk_layer") || strstr(low, "hook") || strstr(low, "overlay") || strstr(low, "reshade");
if (strstr(low, "vklayer_khronos")) return 0;
return strstr(low, "vk_layer") || strstr(low, "vklayer") || strstr(low, "hook") || strstr(low, "overlay") ||
strstr(low, "reshade") || strstr(low, "obs-vulkan") || strstr(low, "nvspcap");
}
// Set when main_run has returned: the mode's work is done and saved, and all that still runs is the C runtime's exit