mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-18 21:49:57 -04:00
Turn NX2NAVI_SPLIT_IDLE off by default: it made the foliage flicker.
Tested in the 0.6.1 test build (RTX 5090, Kokiri Forest), switching the frame rate changes off in turn: the foliage flickered with split_idle on alone and not with it off, with render target image reuse on either way. split_idle sends a submission's first part to the GPU at the first pass boundary after a draw or dispatch while the GPU is idle, without the usual draw and time minimums; why parts cut that early make the foliage flicker is not known yet. The settings file's two stacked descriptions of the split settings, left by the merge, are one again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -165,16 +165,14 @@
|
||||
# only the dynamic states whose values changed since the last pipeline.
|
||||
# bind_reuse = 1
|
||||
# dyn_delta = 1
|
||||
# Submit GPU work in parts every N draws between passes so the GPU starts earlier (0 to 1000; 0 = off), each part at
|
||||
# least split_us microseconds long (0 to 20000).
|
||||
# Submit GPU work in parts every N draws so the GPU starts earlier (0 to 1000; 0 = off), each part at least split_us
|
||||
# microseconds long (0 to 20000). split_in_pass = 1 also splits inside a long pass (it ends there and begins again in the
|
||||
# next part); 0 splits between passes only. split_idle = 1 sends a submission's first part at the first pass boundary
|
||||
# while the GPU has nothing else to run.
|
||||
# while the GPU has nothing else to run; it made the foliage flicker in Kokiri Forest, so it is off by default.
|
||||
# split_draws = 64
|
||||
# split_us = 1000
|
||||
# split_in_pass = 1
|
||||
# split_idle = 1
|
||||
# split_idle = 0
|
||||
|
||||
# Vulkan.
|
||||
# Vulkan validation layer: checks every call and slows the game down a lot. Needs the layer installed (Vulkan SDK).
|
||||
|
||||
@@ -215,7 +215,7 @@ static const CfgMeta metas[] = {
|
||||
{"BIND_REUSE", "1", "0|1", RESTART}, {"DYN_DELTA", "1", "0|1", RESTART},
|
||||
{"DESC_TEMPLATE", "1", "0|1", RESTART},
|
||||
{"PUSH_SKIP", "1", "0|1", RESTART}, {"SPLIT_DRAWS", "64", "0..1000", RESTART},
|
||||
{"SPLIT_US", "1000", "0..20000", RESTART}, {"SPLIT_IDLE", "1", "0|1", RESTART}, {"SPLIT_IN_PASS", "1", "0|1", RESTART},
|
||||
{"SPLIT_US", "1000", "0..20000", RESTART}, {"SPLIT_IDLE", "0", "0|1", RESTART}, {"SPLIT_IN_PASS", "1", "0|1", RESTART},
|
||||
// Vulkan
|
||||
{"VK_VALIDATION", "0", "0|1", RESTART}, {"VK_DYN_VERTEX", "", "0|1", RESTART},
|
||||
{"VK_DYN_A2C", "", "0|1", RESTART}, {"VK_SUBGROUP_PIN", "1", "0|1", RESTART},
|
||||
|
||||
@@ -874,10 +874,12 @@ static void set_rt(VkExec *ex, const p_set_rt *r) {
|
||||
// A part also spans at least NX2NAVI_SPLIT_US (1000) of replay time: a split costs about 40 us of the render thread
|
||||
// (vkQueueSubmit2, a command buffer, the mirror prologue), and a fight frame of 2,000 draws made 15 parts on the 7900X;
|
||||
// a millisecond of recording is a fraction of a millisecond of GPU work, so the GPU still starts early.
|
||||
// Neither limit holds the first part of a submission back while the GPU has run everything submitted (NX2NAVI_SPLIT_IDLE,
|
||||
// on): it goes at the first pass boundary after a draw or dispatch. Each frame the game's thread waits for the GPU to run
|
||||
// the frame's first submission (nvn_api_core.c nvnQueueSubmitCommands, NX2NAVI_SUBMIT_FINISH), so the GPU is idle
|
||||
// when the next one replays, and waited for the first 64 draws and 1 ms of it in Kokiri Forest (2026-11-09).
|
||||
// With NX2NAVI_SPLIT_IDLE=1, neither limit holds the first part of a submission back while the GPU has run everything
|
||||
// submitted: it goes at the first pass boundary after a draw or dispatch. Each frame the game's thread waits for the GPU
|
||||
// to run the frame's first submission (nvn_api_core.c nvnQueueSubmitCommands, NX2NAVI_SUBMIT_FINISH), so the GPU is idle
|
||||
// when the next one replays, and waited for the first 64 draws and 1 ms of it in Kokiri Forest (2026-11-09). Off by
|
||||
// default: with it the foliage of Kokiri Forest flickered (RTX 5090, 2026-11-09), and the parts it cuts that early are
|
||||
// the one thing it changes; why they matter is not known yet.
|
||||
// Both limits also split inside a pass (NX2NAVI_SPLIT_IN_PASS, on): the pass ends there and the next draw begins it
|
||||
// again in the new part, as after a barrier (attachments load and store; occlusion queries continue in a new segment).
|
||||
// Kokiri Forest's two scene passes of ~500 draws take 2-4 ms each to replay and most of the frame's GPU time; split only
|
||||
|
||||
Reference in New Issue
Block a user