mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-15 19:19:58 -04:00
7684734b47
perf.c rt_knob reads "0" as off, "ab" as the A/B blocks and everything else as on, without a word: "cache_die = off", "crash_filter_guard = false" and "one_per_core = 0 ; x" all read as 1 (the audit's probe, Fv/knob.exe, cut rt_knob out with cfg.c: three 1s and no log line). A player who wrote such a value meant the opposite and had no way to learn it from the log. rt_knob now logs "cfg: NX2NAVI_<name> = '<value>' is not 0, 1 or ab: read as 1" the first time it reads such a value for a switch. The value still reads as 1: reading words as 0 changes what a written setting does and waits for approval with F-8. Most of the 109 call sites keep the result in a static but some read it per call, so the warned names are kept in a table of 32 pointers (the names are string literals) filled by compare-and-swap; 0, 1 and ab pay only one more string compare. New tests/rt_knob_check.py cuts rt_knob and its table out of perf.c and builds them with stand-ins for the settings and the log: 0, 1, ab, empty and unset read as before without a line; off, false and "0 ; a note" read as 1 and log once each however often they are read. docs/building.md describes it. The fault was shown before the change by the audit's probe; rt_knob_check passes, and perf.c compiles with the dev flags and with -Wall -Wextra without new warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>