mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-19 02:09:57 -04:00
Make wb_lazy_unlocked = 0 bring back 0.10.1's locking in evictions and releases as well, which the review found it did not.
With the setting at 0, frz_lock was held across every fault's and release's fetch again and mem_thaw released under the lock, but two parts of the new code stayed. vk_memory.c mirror_evict and hot_check still fetched their victims' armed ranges before taking pool_lock again, and a release still put up to 16 copies in one submission. Those are the parts that run only with a device and have no check without one, so a device loss caused by them was the one case the switch could not take back. Now vk_memory.c reads the setting too (evict_unlocked, once on the replay thread, where both run): at 0 neither drops pool_lock, and the release under it fetches everything, victim by victim, as before. And memory.c lazy_take_batch_locked takes one segment at a time at 0, so each is fetched on its own. What stays at 0 is the table of ranges in flight: a touch of a range being fetched waits for that fetch and runs again (a write no longer goes on to thaw_fault and releases its region), the hold is set as the range goes out, and mem_lazy_touches counts the range. memory.c "Ranges in flight", nx2navi.ini.example and docs/building.md say so. tests/lazy_fetch_check.py gains locked_release, the release scenario at 0: three fetches of one copy each, where the batched release makes two of up to two copies. It fails with the cap taken out. The eviction's side has a compile check only. Not reproduced before the change; lazy_fetch_check passed in all its scenarios. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1187,8 +1187,9 @@
|
||||
# With wb_lazy: 1 (default): when the game's CPU code touches memory the video card wrote, the copy that brings it
|
||||
# back holds up only the threads that touch that memory; the game's other threads, the video card's bookkeeping and
|
||||
# file reads go on meanwhile, and several such copies can run at once. 0: every such copy holds them all up until it
|
||||
# is done, as in 0.10.1. Set 0 if the game ends or the graphics device is lost where it did not before, and send the
|
||||
# log.
|
||||
# is done and the copies run one at a time, also those made when video memory runs short, as in 0.10.1; only a thread
|
||||
# that touches memory while it is being copied still waits for that copy alone. Set 0 if the game ends or the graphics
|
||||
# device is lost where it did not before, and send the log.
|
||||
# wb_lazy_unlocked = 1
|
||||
# Barriers between the game's draw passes and compute dispatches. 1: only where the game itself asks for one, or where
|
||||
# the work changes between drawing and compute; this takes about a tenth off the graphics card's time for a frame.
|
||||
|
||||
Reference in New Issue
Block a user