mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-19 12:59:58 -04:00
Say what upscaler_idle_wait = 1 brings back and what it does not.
The review of 9071dfc3 found that nx2navi.ini.example, cfg.c's metas comment, the commit message and docs/architecture.md said the rollback switch works "as up to 0.10.1", which it does not exactly. With 1, every place that lets something go waits for the device again, C-5's queue-lock hazard with it, but what was let go of still goes through vk_dlaa.c's list and vk_memory.c's deferred destruction, the motion vectors and the HUD-less picture keep their 8-present gate, vk_upscaler_settle leaves what the submission being recorded names, stale_sizes waits once per call, and a refused DLSS creation with features let go of still listed waits and tries again, where 0.10.1 turned DLAA off. Each difference is the safer side. The ini line now says that the game waits at each change as up to 0.10.1 while what was let go of still goes once the card is past it; cfg.c, vk_dlaa.c's "what the upscalers let go of" and docs/architecture.md say the same. Comments and docs only. Checks that passed: cfg_rows_check (0 problems), upscaler_idle_check, cfg.c and vk_dlaa.c compile with -Wall -Wextra and no warning, tools/check_content.py --staged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -217,7 +217,8 @@ static const CfgMeta metas[] = {
|
||||
{"SCENE_SHARE", "0.75", "0..1", LIVE},
|
||||
{"DLAA", "0", "0|1", LIVE}, {"DLSS", "dlaa", "dlaa|quality|balanced|performance|ultra_performance", LIVE},
|
||||
{"DLSS_PRESET", "default", "default|k|j", LIVE}, {"DLSS_IDLE_FREE", "1", "0|1|2", RESTART}, {"TAA", "dlss", "dlss|fsr3", LIVE}, // vk_dlaa.c fsr3
|
||||
// vk_dlaa.c vk_upscaler_idle_wait: 1 waits for the device to be idle before an upscaler frees anything, as up to 0.10.1
|
||||
// vk_dlaa.c vk_upscaler_idle_wait: 1 waits for the device to be idle wherever an upscaler lets go of something, as up
|
||||
// to 0.10.1 (what was let go of still goes once the GPU is past it, behind its present gate)
|
||||
{"UPSCALER_IDLE_WAIT", "0", "0|1", RESTART},
|
||||
{"DLSS_RANGE", "0", "0|1", RESTART}, // vk_dlaa.c range_on: one DLSS feature for the render sizes of a mode
|
||||
{"DLSS_PREBLOOM", "0", "0|1", LIVE}, // vk_dlaa.c prebloom_run: DLSS or FSR 3.1 before the bloom, not after the tonemap
|
||||
|
||||
Reference in New Issue
Block a user