mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-17 04:59:57 -04:00
Write the frame-time summary and the stutter map at a fatal error too, the map only when its lock is free.
dispatch.c fatal_end wrote only the profiler's samples, so a run that ended in a FATAL had no "frametime" or stutter-map lines for its last period: the numbers that would show what the game was doing before it failed. perf.c perf_summary_flush_try (weak in dispatch.c for builds without perf.c) runs after fs_save_crash_wait: ft_stop, then the running period's "frametime: at a fatal error" lines and the stutter map. The failing thread may hold any lock, so stutter_map.c gains stutter_report_as(tag, try_only), which only tries sm_lock and writes nothing when it is taken (stutter_report keeps the blocking take); the back end's exit lines (gfx_exit_log) and the trace's segments (seg_close) are left out, as they read state the failure may have left half made. The crash report keeps no summary: its state may be damaged. Not reproduced before the change (a missing diagnostic). tests/fatal_exit_check.py now wants the summary at rt_fatal and checks statically that perf_summary_flush_try only tries the map's lock and leaves the back end out; tests/stutter_hitch_check.c gets the trylock stand-in it needs. fatal_exit_check, stutter_hitch_check, stutter_map_check and the compile checks of every runtime file pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -775,6 +775,19 @@ void perf_summary_flush(void) { // at exit (prof_write)
|
||||
summary_t0 = 0;
|
||||
}
|
||||
|
||||
// A fatal error's frame-time summary (dispatch.c fatal_end), on the failing thread, which may hold any lock: the
|
||||
// running period's "frametime" lines and the stutter map so far, the map only when its lock is free. The back end's
|
||||
// exit lines (gfx_exit_log) and the trace's segments (seg_close) are left out: they read state the failure may have
|
||||
// left half made. The present thread's numbers may be caught mid-frame if it still runs past ft_stop's wait.
|
||||
void perf_summary_flush_try(void) {
|
||||
ft_stop();
|
||||
if (summary_t0) {
|
||||
ft_report(kern_now_ns(), "at a fatal error");
|
||||
if (!stutter_report_as("at a fatal error", 1)) rt_log("stutter map: its lock is held; not written at the fatal error");
|
||||
}
|
||||
summary_t0 = 0;
|
||||
}
|
||||
|
||||
// Returns the replay time since the previous present. add 0: the exit's summary is written (ft_stop), so the frame
|
||||
// is not added to it.
|
||||
static uint64_t ft_frame(uint64_t frame, uint64_t now, uint64_t d, int add) {
|
||||
|
||||
Reference in New Issue
Block a user