From b8d7eede0816e0d12e6469398a515d1e13214c53 Mon Sep 17 00:00:00 2001 From: chrg6 Date: Sun, 8 Nov 2026 09:24:37 -0500 Subject: [PATCH] Keep presenting after a present submit fails, and ignore a crop outside the image. - The present resets its slot's fence after the acquire. When the submit then failed (out of device or host memory), the fence stayed unsignalled and the acquire's semaphore signalled: the slot's next fence wait timed out after 5 s, the frame counter no longer moved on, and every later present waited on the same slot, so the picture stopped for good while each game submit waited behind it. An empty batch now takes the semaphore and signals the fence, and the swapchain is made again, which gives the acquired image back. - A crop from the game's nvnWindowSetCrop that starts past the image gave a blit with an inverted source rectangle; the whole image is shown then. Co-Authored-By: Claude Opus 5.5 --- runtime/gfx_present.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/runtime/gfx_present.c b/runtime/gfx_present.c index b2c2e6b7..b22ada1d 100644 --- a/runtime/gfx_present.c +++ b/runtime/gfx_present.c @@ -921,6 +921,8 @@ static void present_image(VkImage src, VkImageLayout layout, VkFormat fmt, int w if (cy < 0) cy = 0; if (cx + cw > w) cw = w - cx; if (cy + ch > h) ch = h - cy; + if (cw <= 0 || ch <= 0) cx = cy = 0, cw = w, ch = h; // a crop outside the image (the game's nvnWindowSetCrop): + // the whole image, not an inverted blit rectangle window_settings_live(); // The menu overlay: laid out before recording (its first frame starts the ImGui back end and uploads the font) const char *menu_shot = NULL; @@ -1066,6 +1068,16 @@ static void present_image(VkImage src, VkImageLayout layout, VkFormat fmt, int w } else { vk_device_fault_report(r); rt_log("gfx: present submit failed (%d)", (int)r); + // The fence was reset after the acquire and the acquire's semaphore is signalled: left so, this slot's fence + // wait would time out (5 s) at every later present and the picture stop for good. An empty batch takes the + // semaphore and signals the fence; the acquired image goes back with the swapchain, made again next frame. + VkSubmitInfo2 settle = {.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO_2, .waitSemaphoreInfoCount = 1, + .pWaitSemaphoreInfos = &wait}; + vk_queue_lock(); + VkResult r2 = vkQueueSubmit2(c->gfx_queue, 1, &settle, g_fence[slot]); + vk_queue_unlock(); + if (r2 != VK_SUCCESS) rt_log("gfx: the present slot could not be settled either (%d)", (int)r2); + plat_xchg32(&g_dirty, 1); } g_frame++; if (cap) {