mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-18 21:49:57 -04:00
Correct the comments on RivaTuner Statistics Server's pacing beside the ceiling, the state file's writers and the crash path.
The review found three comments that claimed more than the code does. rtss_decide.h rtss_pace_period and frame_rate.c (above frame_step_cap_ns) said the frames RTSS lets through always come further apart than the 240 ceiling, so the two limiters never stack: at a limit of 240, or unlimited, which RTSS gets as 240, the ceiling is RTSS's own period, and both may hold a frame. rtss_limit.c state_put said it runs on the worker thread only, but rtss_limit_restore's put back calls it on the exiting thread, under the lock. And rtss_limit.c's header said a crash and a fatal error make no call into RTSS's library, which holds only while the state file has the run's line. The comments now say so, and the header names the exception at 240. (The comment above rtss_decide was rewrapped and lost its reference to rtss_fresh with the unproven-hold rule.) No behaviour changes. Checks that passed: tests/rtss_limit_check.py, tests/frame_step_check.py, pass_cc_check.py --wall on rtss_limit.c and frame_rate.c (only frame_rate.c's existing game_interval warning), tools/check_content.py --staged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -275,8 +275,9 @@ double frame_step_game_hz(void) {
|
||||
}
|
||||
|
||||
// RivaTuner Statistics Server (rtss_limit.c) gets the same limit; while it limits this process the pacer holds the
|
||||
// frames only to LIMIT_FREE_MAX_HZ, the ceiling the game's code needs, so the two never stack, and it takes the limit
|
||||
// back once no picture went out for 200 ms (rtss_decide.h rtss_pace_period): a minimised window or a frame hold leaves
|
||||
// frames only to LIMIT_FREE_MAX_HZ, the ceiling the game's code needs, so the two do not stack, except at a limit of
|
||||
// 240 or unlimited, where the ceiling is RTSS's own period; and it takes the limit back once no picture went out for
|
||||
// 200 ms (rtss_decide.h rtss_pace_period): a minimised window or a frame hold leaves
|
||||
// RTSS no present to hold. While a movie plays the pacer holds the movie's rate and keeps its slots whatever RTSS does.
|
||||
// NX2NAVI_RTSS=0 and frame generation (RTSS would count the generated frames) keep it out, and so does a driver's low
|
||||
// latency while it is in effect (vk_lowlat.c): the driver holds the limit where the frame starts, and RTSS would hold
|
||||
|
||||
Reference in New Issue
Block a user