mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-18 00:29:58 -04:00
Uninstall only what the launcher put in its folder, so a kept game folder inside it stays.
Uninstall ran rmdir /s on the whole launcher folder, which holds the default game folder (<launcher>\game) and, with the setup's --dest, whatever else the player keeps there: "Remove the Built Game" Off would have deleted the game and its saves. It now deletes NX2navi.exe, python, app, pydeps, data, toolchain and python.old-*, then the folder only when that left it empty, and for a toolchain in C:\NX2navi that toolchain, then C:\NX2navi only when empty. The command also never ran: it went to cmd.exe as a list, whose quotes Python escapes as \", which cmd.exe does not understand, so every rmdir failed and nothing was removed. It is now one command line. tests/launcher_test.py runs it on a folder with spaces and a character outside ASCII. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -164,9 +164,11 @@ it), and what to check: the date, time and time zone, or security software that
|
||||
|
||||
## Uninstalling
|
||||
|
||||
Settings > Uninstall NX2navi, or Settings > Apps > NX2navi (which runs `NX2navi.exe --uninstall`): the launcher
|
||||
folder, its toolchain, the shortcuts and the Apps entry go; the built game and its saves stay unless "Remove the
|
||||
Built Game" is On. The dump is never touched.
|
||||
Settings > Uninstall NX2navi, or Settings > Apps > NX2navi (which runs `NX2navi.exe --uninstall`): what the launcher
|
||||
put in its folder (`NX2navi.exe`, `python`, `app`, `pydeps`, `data`, `toolchain`; `launcher/winsys.py` `OWNED`), the
|
||||
toolchain in `C:\NX2navi` when it went there, the shortcuts and the Apps entry go; the launcher's folder itself goes
|
||||
only when that leaves it empty. The built game and its saves stay unless "Remove the Built Game" is On, also when the
|
||||
game folder is the default `<launcher>\game`. The dump is never touched.
|
||||
|
||||
## Command line
|
||||
|
||||
|
||||
Reference in New Issue
Block a user