mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-17 22:19:57 -04:00
Tie the stutter map's cause count to perf.c's at compile time, and rewrap the comment that lists the causes.
The review of d84aa5fb and c05e6528 found that nothing at compile time tied perf.c FT_C_N to stutter_map.c SM_CAUSES: they sit in different translation units, perf.c ft_frame passes stutter_frame n = FT_C_N, and the areas' by_cause counts and cause_short are indexed against SM_CAUSES, so a cause added on one side only would mislabel the map without an error (tests/stutter_hitch_check.c checks only its own names[]). stutter_map.h now defines STUTTER_CAUSES, stutter_map.c sizes SM_CAUSES from it, and perf.c asserts FT_C_N == STUTTER_CAUSES beside the FT_C_* list. With STUTTER_CAUSES set to 11 the assertion stops perf.c's compile. The review also found that the header comment line of stutter_map.c listing the causes ran to 142 columns, where the file wraps at 120; the paragraph is rewrapped without a change of words. No change to what runs. perf.c, stutter_map.c and the other files that include stutter_map.h (romfs.c, vk_exec_draw.c, vk_pipeline.c) compile with the dev flags, perf.c and stutter_map.c add no -Wall -Wextra warnings, and stutter_hitch_check and stutter_map_check pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -22,6 +22,9 @@ void stutter_miss(int shader, int mesh, const uint8_t *vi, const uint8_t *fi, ui
|
||||
void stutter_ready(int mesh, const uint8_t *vi, const uint8_t *fi, double ms, int recorded, int fresh, int fast);
|
||||
// Every present (perf.c ft_frame): d the frame's interval, part the time it went to by cause (names[i], n of them;
|
||||
// the last one is the part nothing recorded explains), cause the one the frame is charged to.
|
||||
// STUTTER_CAUSES: the number of causes, perf.c's FT_C_N (perf.c asserts it), which stutter_map.c cause_short and the
|
||||
// areas' counts are sized by; n is that many.
|
||||
#define STUTTER_CAUSES 10
|
||||
void stutter_frame(uint64_t frame, uint64_t now, uint64_t d, const uint64_t *part, const char *const *names, int n,
|
||||
int cause);
|
||||
void stutter_report(const char *tag); // the map so far; every 5 minutes of play, at a focus loss in play and at exit
|
||||
|
||||
Reference in New Issue
Block a user