mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-19 04:19:57 -04:00
Tie the stutter map's cause count to perf.c's at compile time, and rewrap the comment that lists the causes.
The review of d84aa5fb and c05e6528 found that nothing at compile time tied perf.c FT_C_N to stutter_map.c SM_CAUSES: they sit in different translation units, perf.c ft_frame passes stutter_frame n = FT_C_N, and the areas' by_cause counts and cause_short are indexed against SM_CAUSES, so a cause added on one side only would mislabel the map without an error (tests/stutter_hitch_check.c checks only its own names[]). stutter_map.h now defines STUTTER_CAUSES, stutter_map.c sizes SM_CAUSES from it, and perf.c asserts FT_C_N == STUTTER_CAUSES beside the FT_C_* list. With STUTTER_CAUSES set to 11 the assertion stops perf.c's compile. The review also found that the header comment line of stutter_map.c listing the causes ran to 142 columns, where the file wraps at 120; the paragraph is rewrapped without a change of words. No change to what runs. perf.c, stutter_map.c and the other files that include stutter_map.h (romfs.c, vk_exec_draw.c, vk_pipeline.c) compile with the dev flags, perf.c and stutter_map.c add no -Wall -Wextra warnings, and stutter_hitch_check and stutter_map_check pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -478,6 +478,7 @@ typedef struct {
|
||||
// stutter_map.c cause_short and tools/stutter_map.py read these names, in this order.
|
||||
enum { FT_C_PIPE, FT_C_XLATE, FT_C_TEX, FT_C_FENCE, FT_C_PACE, FT_C_HANDOFF, FT_C_REPLAY, FT_C_CENSUS, FT_C_REPORT,
|
||||
FT_C_OTHER, FT_C_N };
|
||||
_Static_assert(FT_C_N == STUTTER_CAUSES, "stutter_map.c cause_short and its counts follow FT_C_*");
|
||||
static const char *const ft_cause_name[FT_C_N] = { "pipeline", "translation", "texture", "fence", "pacing", "hand-off",
|
||||
"replay", "census", "report", "unattributed" };
|
||||
static uint64_t census_part_ns; // present thread: the census walks since the last present (census_check)
|
||||
|
||||
Reference in New Issue
Block a user