From 7f7416b38b0dbda9cdc42a184c70cec36c639686 Mon Sep 17 00:00:00 2001 From: chrg6 Date: Thu, 12 Nov 2026 03:26:10 -0500 Subject: [PATCH] Log the voices the game holds in the audio renderer every 10 s with NX2NAVI_AUDIO_STATS. The game's sound engine takes a voice per sound from the renderer's voice count, so sounds that are never let go would show as a count that climbs from area to area until new sounds are refused. The line gives the voices in use, those playing, the renderer's voice count and the most a census found so far. Used to check whether the sound engine leaks voices above 60 fps: through eight reloads of Kakariko the most was 30 of 96 at a 60 fps limit and 31 at 144, and every return to the title brought the count back to 12 at both rates. Co-Authored-By: Claude Opus 5.5 --- runtime/audren.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/runtime/audren.c b/runtime/audren.c index f5d9b490..b2c5617b 100644 --- a/runtime/audren.c +++ b/runtime/audren.c @@ -48,6 +48,8 @@ typedef struct AudrenStats { // voices (under the lock) uint64_t dry, late[3], late_max; // next buffer late by 1-2 passes, 3-8, 9-AS_LATE_PASSES int events; + uint64_t voices_ns; // the game's update (under the lock): the last voice census line + int voices_most; // the most voices in use a census found } AudrenStats; // NX2NAVI_AUDIO_GAME_PRIO (default 0): the host priority of the game's thread that sends RequestUpdate. 0 leaves it @@ -372,6 +374,7 @@ static void request_update(AudioRenderer *r, const uint8_t *input, uint64_t in_s memcpy(w, &r->elapsed_frames, 8); AudrenStats *st = r->stats; uint64_t late_gap = 0, late_passes = 0; + int voices_line = 0, voices_used = 0, voices_playing = 0, voices_most = 0; if (st) { // NX2NAVI_AUDIO_STATS: the game's cadence and how long its update held the lock uint64_t now = kern_now_ns(), gap = st->upd_last_ns ? now - st->upd_last_ns : 0, passes = st->upd_last_ns ? r->elapsed_frames - st->upd_pass_last : 0; @@ -382,8 +385,21 @@ static void request_update(AudioRenderer *r, const uint8_t *input, uint64_t in_s if (gap > AS_UPDATE_EVENT_NS && r->state == 0 && st->events < AS_EVENTS) st->events++, late_gap = gap, late_passes = passes; st->upd_last_ns = now, st->upd_pass_last = r->elapsed_frames, st->upd_n++; + // The voices the game holds: its sound engine takes one per sound from a budget of the renderer's voice count, + // so sounds that are never let go show as a count that climbs from area to area until new sounds are refused. + if (now - st->voices_ns >= AS_WINDOW_NS) { + int used = 0, playing = 0; + for (int k = 0; k < r->param.voice_count; k++) + used += r->voices[k].in.in_use != 0, playing += r->voices[k].in.in_use && r->voices[k].state == SV_STARTED; + if (used > st->voices_most) st->voices_most = used; + st->voices_ns = now; + voices_line = 1, voices_used = used, voices_playing = playing, voices_most = st->voices_most; + } } plat_mutex_unlock(&r->lock); + if (voices_line) + rt_log("audio: voices in use %d, playing %d, of %d (the most so far %d), game frame %llu", voices_used, + voices_playing, r->param.voice_count, voices_most, (unsigned long long)game_frame()); if (late_gap) rt_log("audio: the game's audio update came %.1f ms after its last one (%llu render passes of 5 ms), game frame " "%llu", late_gap / 1e6, (unsigned long long)late_passes, (unsigned long long)game_frame());