mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-17 13:39:58 -04:00
Let the wait after a frame's first submission cover the write-backs under shadow storage.
With shadow storage (the Linux default) what the GPU wrote reaches guest memory in the fence's completion callback, later than an import's store on the GPU. The wait after a frame's first submission returned at the executed timeline, before that, so the game rewrote what those passes had written and the write-back then put the GPU's older bytes back over the rewrite. The whole 3D scene came out brighter for single frames, each of them a frame whose main work was held at its CPU event wait and replayed late. Standing outdoors with NX2NAVI_SHADOW=1 on an RTX 5090: 695, 624, 443, 323 and 2 flashed frames of 1,800 in five runs with the split, none in eight runs without it. The frame rate did not drop (74.6 fps median with the fix; runs of the build before it gave 71 to 72). NX2NAVI_WB_SPLIT=2 keeps the split with shadow storage, to measure the fault. That this is the flicker a player reported on Linux (RX 7800 XT, RADV) is not confirmed on their machine; NX2NAVI_WB_SPLIT=0 gives 0.7.1 the same wait there. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This commit is contained in:
@@ -272,7 +272,10 @@ writes come back at its fence. Pages both sides write keep a base copy, so each
|
||||
a VRAM mirror's write-back merge marks the pages it changed, and only those are compared at the fence; a lookup that
|
||||
reads guest memory itself (the uniform snapshot, `vk_mem_lookup`) does not queue its pool for the copy-in. In Kokiri
|
||||
Forest (1.1.1, RTX 4090) that costs about 1 ms a frame (copy-in 0.5 ms, write-back 0.6 ms), and the copies hold about
|
||||
5 GB. `NX2NAVI_SHADOW=1` turns it on under Windows too. The Steam Deck's RADV has `VK_EXT_external_memory_host` as
|
||||
5 GB. The GPU's bytes reach guest memory in the fence's completion callback, later than an import's, so the wait
|
||||
after a frame's first submission covers the write-backs there (`runtime/vk_sync.c`, "the executed timeline"): the game
|
||||
rewrites what those passes wrote without a fence, and a write-back that landed after the rewrite left the GPU adding
|
||||
light onto its own last output, the whole scene brighter for a frame. `NX2NAVI_SHADOW=1` turns it on under Windows too. The Steam Deck's RADV has `VK_EXT_external_memory_host` as
|
||||
well: the shadow copies are chosen for the measured cost above, not for a missing extension.
|
||||
|
||||
The device address table (`runtime/vk_gpa.c`) names a pool's shadow copy as it names an import, so shaders follow guest
|
||||
|
||||
Reference in New Issue
Block a user