mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-19 10:49:58 -04:00
Leave a patch of grass out whole while its colour draw waits for a pipeline on the mesh shader fallback.
The game draws a culled list of grass or leaves twice from one indirect record: into the depth target alone, then into the colour targets. On the mesh shader fallback each draw has compute modules and a pipeline of its own, made at its first draw, and the depth-only one is ready first. Drawn alone it left the list's depth in the scene with nothing drawn over it, so what lies behind failed the depth test there and the sky's colour showed through the ground in the shape of the grass for as long as the colour draw's pipeline built, which is seconds each on AMD's driver for Radeon RX 6000 and older, where the fallback is the default. A colour draw skipped for its modules or pipeline now stamps its record's address with the present, and clears the stamp when it is drawn. The depth-only draw of a record stamped within the last two presents is skipped as well, counted like a draw whose own pipeline is building. A draw whose stages write memory is never held. mesh_fallback_hold = 0 draws the depth alone as before. Not run: no card here takes the fallback by default, and the game is the user's to start. The changed file compiles and the settings table's check reports 0 problems. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This commit is contained in:
@@ -189,6 +189,10 @@ keeps per-core data without locks and relies on that, so the host models it (`ru
|
||||
they are ready (`mesh_fallback_workers`, auto: one for each 4 logical processors, 1 to 4, so a place's programs,
|
||||
which all arrive in its first frames, are not made one after the other); they are not recorded for the next start,
|
||||
where the pipeline cache makes them quick.
|
||||
- The game draws a culled list of grass or leaves twice from one indirect record, depth first and colour after, and
|
||||
the depth draw's smaller program is ready first. While the colour draw is skipped for its modules or pipeline,
|
||||
the depth draw of the same record is skipped too (`mfb_hold_role`, `mesh_fallback_hold`): alone it left the
|
||||
list's depth in the scene with nothing drawn over it, and the sky's colour showed through the ground.
|
||||
Not carried: the far shadow cascades' coarser shading rate, a draw's first workgroup other than 0, and more
|
||||
workgroups in one draw than one compute dispatch may have.
|
||||
- Pipelines: `VK_EXT_graphics_pipeline_library` where the driver has it: stage libraries compiled ahead, a fast link
|
||||
|
||||
@@ -34,6 +34,9 @@ cards).
|
||||
- **AMD Radeon RX 5000 and 6000 cards losing the device** (the game ending with code 72): on AMD's driver these cards
|
||||
now take the mesh shader fallback by default (`mesh_fallback = auto`), and a lost device is noticed and reported
|
||||
sooner. Not yet confirmed by players with these cards: please report how it goes.
|
||||
- **Sky-coloured holes in the ground where grass is still loading**, on cards that take the mesh shader fallback: a
|
||||
patch of grass or leaves is now left out whole until it is ready, where its depth alone was drawn before
|
||||
(`mesh_fallback_hold = 0` brings that back). Not yet confirmed by players with these cards either.
|
||||
- **Crashes and hangs found in a review of the whole runtime**; none was seen in our own play, and each fix has a check
|
||||
of its own:
|
||||
- a crash when the game read memory the lazy write-back was just handing to the GPU (NVIDIA and Intel cards);
|
||||
@@ -88,6 +91,6 @@ cards).
|
||||
- In `nx2navi.ini`, a comment after a value (`pace_smooth = 0 ; off`) and the words `off`, `false` and `no` now mean
|
||||
what they say for on/off settings; before, such a line could turn the setting on. Paths and names keep their whole
|
||||
text.
|
||||
- New: `reflex_limit`, `ocarina_timing`, `audio_strict`, `hang_watch_s`, and switches that bring back the earlier
|
||||
behaviour of this release's larger changes should one cause trouble: `upscaler_idle_wait`, `present_order`,
|
||||
`wb_lazy_unlocked`. See `nx2navi.ini.example`.
|
||||
- New: `reflex_limit`, `ocarina_timing`, `audio_strict`, `hang_watch_s`, `mesh_fallback_hold`, and switches that
|
||||
bring back the earlier behaviour of this release's larger changes should one cause trouble: `upscaler_idle_wait`,
|
||||
`present_order`, `wb_lazy_unlocked`. See `nx2navi.ini.example`.
|
||||
|
||||
Reference in New Issue
Block a user