Stop sending a request again to a new translator child after the first one gave no answer for the read timeout.

plat_child_read returned -1 both for a broken pipe and for a child that sent nothing for PLAT_CHILD_READ_MS (120 s),
and svc_request retried any failure once on a fresh child. The translator is deterministic, so a program it hangs on
hangs the second child too: a compute shader, which the replay thread looks up synchronously (vk_exec_draw.c
shader_for), held the game for about 4 minutes instead of 2. plat_child_read now returns -2 on the timeout (win32.c and
linux.c), child_exchange_raw returns 1, 0 for a broken pipe or a child that could not start, and -1 for the timeout,
and svc_request stops the child and gives -1 without asking again; a dead child is still restarted once.
translate_one fails such a request with its own reason, keeps its job and code for diagnosis and deletes whatever the
stopped child wrote. The carry pass's child runs at idle priority, so a busy machine can starve it that long:
carry_exchange does not resend after a timeout either, and carry_translate counts it as a failed input, not as an
unavailable translator, so one slow program does not count towards the three that stop the pass. platform.h lets a
build set PLAT_CHILD_READ_MS.

Not reproduced before the change (no translator hang appears in the available logs). tests/child_timeout_check.py
(new) builds the real child and request functions with a 300 ms timeout: a silent child gives -2 and costs one
timeout with one child started, an exiting child is restarted once, an answering child gives its line. Every runtime
file compiles, with no new warnings in gfx_shader.c and win32.c.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
chrg6
2026-11-13 17:08:45 -05:00
parent 46c764a434
commit 72047d12af
6 changed files with 231 additions and 22 deletions

View File

@@ -2384,15 +2384,16 @@ int plat_child_write(PlatChild *c, const void *data, size_t n) {
}
// A child that stays alive but never answers (a translator stuck on one program) used to block the reader for good,
// and with it the draw or dispatch waiting for that shader: after PLAT_CHILD_READ_MS without a byte the read fails,
// and the caller stops the child (gfx_shader.c svc_request). The pipe is anonymous, so readiness is polled.
// and with it the draw or dispatch waiting for that shader: after PLAT_CHILD_READ_MS without a byte the read fails
// with -2, apart from the -1 of a broken pipe, and the caller stops the child without sending the request again
// (gfx_shader.c svc_request). The pipe is anonymous, so readiness is polled.
long plat_child_read(PlatChild *c, void *buf, size_t cap) {
ULONGLONG t0 = GetTickCount64();
for (unsigned spins = 0;; spins++) {
DWORD avail = 0;
if (!PeekNamedPipe(c->out, NULL, 0, NULL, &avail, NULL)) return -1; // broken: the child exited
if (avail) break;
if (GetTickCount64() - t0 > PLAT_CHILD_READ_MS) return -1;
if (GetTickCount64() - t0 > PLAT_CHILD_READ_MS) return -2;
Sleep(spins < 50 ? 0 : 1);
}
DWORD got = 0;