mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-17 15:49:57 -04:00
Unpack the texture archive in pieces when drawing the button prompts.
pad_prompts.py gave each packed game file to the decompressor in one call, which returns one bytes object grown by copying. On made-up data of the size of the interface texture archive, 69 MB packed and 244 MB unpacked, that takes 21 s on a fast PC; players' builds waited 44 to 52 s before the step's first folder, most of its minute. In 64 KiB pieces joined once the same bytes take 0.3 s. The prompts step's key held the digest of the three scripts' bytes, so this edit would have drawn every install's prompts again, as two of the last four releases did. It now holds a constant changed by hand, whose value is the scripts' digest in 0.7.0 and 0.7.1, and a test fails when the scripts' logic changes, to ask whether the constant must change. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This commit is contained in:
@@ -154,10 +154,13 @@ A path the Windows ANSI code page cannot hold breaks the MSYS2 tools, so the too
|
||||
and writes the Xbox, PlayStation, Steam Deck and keyboard and mouse prompts into `romfs-patches-*` beside the game (about
|
||||
30 s), which the game's Controls > Button prompts loads. The keyboard and mouse prompts show the keys of
|
||||
`nx2navi.ini`'s `bind_` lines, so Rebuild the Game after rebinding keys draws them again; the step's key names
|
||||
all it reads (the RomFS, the art, the tools, those lines), so it runs again only when one changed or a folder is
|
||||
gone, and runs no other step again. Without art the row is not shown and the game keeps its own prompts.
|
||||
all it reads (the RomFS, the art, those lines) and the version of the tools (`make_game.py` `PROMPT_TOOLS`, changed
|
||||
by hand when a change to them changes what they write: an edit of a script alone does not draw the prompts
|
||||
again), so it runs again only when one changed or a folder is gone, and runs no other step again. Without art
|
||||
the row is not shown and the game keeps its own prompts.
|
||||
5. **Check the Game Files**: make_game.py's last step runs `tools/romfs_check.py`, once for each copy of the game data
|
||||
(about 4 minutes, in worker threads, never while the game runs). It decompresses every file, writes
|
||||
(about 4 minutes on players' PCs up to 0.7.1, in worker threads, never while the game runs; its key holds the
|
||||
check's version, `SCAN_TOOL`, in the same way). It decompresses every file, writes
|
||||
`romfs-check.json` beside the game, and for each damaged texture puts a stand-in, another texture of the same kind
|
||||
under the damaged one's name, in `mods/Damaged file stand-ins`, so the game can load what needs it. A damaged file
|
||||
of any other kind is only reported: only a clean dump restores it. In play the game logs a file it keeps opening
|
||||
|
||||
Reference in New Issue
Block a user