From 482f7fdfb5e936e6e0d47f08b142a0062ec4b0df Mon Sep 17 00:00:00 2001 From: chrg6 Date: Fri, 13 Nov 2026 08:33:53 -0500 Subject: [PATCH] Stop logging a replay worker's deferred render target lookup as a target left out, and say why a target that is left out could not be rendered. A chunk's lookup that needs its turn returns no image and its op is replayed in turn, but the first one was logged as "render target ... is not renderable here: left out", which read as depth and cube targets the replay could not draw. Nothing else changes. Co-Authored-By: Claude Opus 5.5 --- runtime/vk_exec.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/runtime/vk_exec.c b/runtime/vk_exec.c index 5b1fbd23..3c65aed9 100644 --- a/runtime/vk_exec.c +++ b/runtime/vk_exec.c @@ -448,9 +448,15 @@ static void resolve_target(const tex_t *t, const view_t *v, int has_v, int depth if (img && !depth_slot && bc_target(t, v, has_v, img, o)) return; // a 3D BC image: its stand-in VkImageUsageFlags need = depth_slot ? VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT : VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; int is3d = img && img->type == VK_IMAGE_TYPE_3D && !depth_slot; // slices drawn through 2D views (2D_ARRAY_COMPATIBLE) + // A replay worker's lookup that needs its turn returns no image (vk_texture_deferred), and the op is replayed again + // in turn (resolve_rt's callers): not a target left out, so not logged as one. Logged, the first such lookup read + // as if the game drew into depth or cube targets the replay could not render. + if (!img && vk_texture_deferred()) return; if (!img || !(img->usage & need) || (img->type != VK_IMAGE_TYPE_2D && !is3d)) { - warn_once(W_UNRENDERABLE, "render target format %#x target %d (%ux%u) is not renderable here: left out", - t->d.format, t->d.target, t->d.width, t->d.height); + warn_once(W_UNRENDERABLE, "render target format %#x target %d (%ux%u) is not renderable here (%s): left out", + t->d.format, t->d.target, t->d.width, t->d.height, + !img ? "no image" : !(img->usage & need) ? (depth_slot ? "no depth attachment usage" : "no colour attachment usage") + : "not a 2D image"); return; } uint32_t level = has_v && v->set_levels ? v->base_level : 0;