mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-17 15:49:57 -04:00
Correct what a review of this intake's commits found.
A second reading of the commits taken in from pull requests found these, each traced in the code: - heap_lazy: the camera speed's search read the whole heap, which with the setting on committed every page and undid what it saves; a scan now steps over the pages the lazy heap never committed (mem_untouched_run). tests/frame_step_check.py and tests/save_share_check.py no longer linked (frame_rate.c and fs_host.c call the new memory functions; the second also missed mem_probing before); both pass again. The settings text says that with the setting on a PC out of commit ends the game in play, not at start, and the census comment is back over its own function. - Pipeline libraries on AMD's older Windows driver: the condition is the driver for RDNA 2 and older (RX 400 to RX 6000), not RX 5000 and RX 6000 only, and the texts named a price the code does not have. With libraries off a new pipeline is built by a worker while its draw is left out, and the start waits for every recorded pipeline instead of 20 s at most. The texts say so, and that the finding is one player's on one card. The menu strings nothing shows are as they were. - Page file hint: it comes only when Windows sizes every page file, and it names the initial size and the automatic management that must be unticked first. - Frame generation note: it keeps "needs an RTX 40 or newer" for the players it is right for and points the others to the log; the bridge's line says it is Streamline's general support check. - Comments and settings texts that still described the old behaviour: the process commit bound, the wait with shadow storage, the scratch's least size, the action prompt under auto. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> (cherry picked from commit 19f03aa01b26d6e17fb5fc70ad987aa8c68e8225)
This commit is contained in:
@@ -1555,6 +1555,9 @@ static int idle(const Tex *e, uint64_t now);
|
||||
// or the page file, and the VRAM pressure and tex_disuse already bound it. Counted in, it held the bound all through
|
||||
// Hyrule Field on a 16 GB PC with a 16 GB card (RTX 5060 Ti): the process at 28.9 to 30.7 GB, 9 to 10 GB of it video
|
||||
// memory, while the system had 8 to 10 GB of its 49 GB limit free, and the ground flickered white as textures gave way.
|
||||
// So on such a PC the 42 GB process above, half of it device memory, no longer reaches this bound: the system's
|
||||
// figure and the VRAM pressure are what act there. The part of a card's memory the driver has moved into shared
|
||||
// system memory is subtracted too, which it should not be; the driver does not report it apart.
|
||||
#define COMMIT_LOW_KEEP ((uint64_t)256 << 20)
|
||||
#define PROC_COMMIT_MIN_MB 24576
|
||||
static uint64_t released_cap; // bytes; 0 = not read yet, UINT64_MAX = no limit
|
||||
@@ -1616,8 +1619,9 @@ static int commit_is_low(void) {
|
||||
char note[2048]; // the platform layer's own lines go to stderr only, so the log file gets this through here
|
||||
if (plat_commit_note(note, sizeof note)) rt_log("platform: %s", note);
|
||||
if (proc_commit_mb)
|
||||
rt_log("vk: textures give way as under low commit while this process's commit is above %lld MB "
|
||||
"(NX2NAVI_TEX_PROC_COMMIT_MB; 0 = off)", proc_commit_mb);
|
||||
rt_log("vk: textures give way as under low commit while this process's commit%s is above %lld MB "
|
||||
"(NX2NAVI_TEX_PROC_COMMIT_MB; 0 = off)",
|
||||
plat_commit_counts_vram() ? ", less the video memory in use on a discrete card," : "", proc_commit_mb);
|
||||
}
|
||||
if (!commit_free_mb && !proc_commit_mb) return 0;
|
||||
double proc, used, limit;
|
||||
@@ -1655,9 +1659,10 @@ static int commit_is_low(void) {
|
||||
static int hinted;
|
||||
if (low && !hinted && plat_page_file_managed() == 1) {
|
||||
hinted = 1;
|
||||
rt_log("vk: the page file is sized by Windows, which grows it only slowly: a fixed page file of at least "
|
||||
"32 GB keeps the system's commit from running low (System > About > Advanced system settings > "
|
||||
"Performance Settings > Advanced > Virtual memory > Change: Custom size, then restart Windows)");
|
||||
rt_log("vk: the page file is sized by Windows, which grows it only slowly: a fixed page file whose initial "
|
||||
"size is at least 32 GB keeps the system's commit from running low (System > About > Advanced system "
|
||||
"settings > Performance Settings > Advanced > Virtual memory > Change: untick the automatic "
|
||||
"management, Custom size with an initial size of 32768 MB or more, Set, then restart Windows)");
|
||||
}
|
||||
}
|
||||
sys_low = low;
|
||||
|
||||
Reference in New Issue
Block a user