mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-16 13:59:56 -04:00
Correct what a review of this intake's commits found.
A second reading of the commits taken in from pull requests found these, each traced in the code: - heap_lazy: the camera speed's search read the whole heap, which with the setting on committed every page and undid what it saves; a scan now steps over the pages the lazy heap never committed (mem_untouched_run). tests/frame_step_check.py and tests/save_share_check.py no longer linked (frame_rate.c and fs_host.c call the new memory functions; the second also missed mem_probing before); both pass again. The settings text says that with the setting on a PC out of commit ends the game in play, not at start, and the census comment is back over its own function. - Pipeline libraries on AMD's older Windows driver: the condition is the driver for RDNA 2 and older (RX 400 to RX 6000), not RX 5000 and RX 6000 only, and the texts named a price the code does not have. With libraries off a new pipeline is built by a worker while its draw is left out, and the start waits for every recorded pipeline instead of 20 s at most. The texts say so, and that the finding is one player's on one card. The menu strings nothing shows are as they were. - Page file hint: it comes only when Windows sizes every page file, and it names the initial size and the automatic management that must be unticked first. - Frame generation note: it keeps "needs an RTX 40 or newer" for the players it is right for and points the others to the log; the bridge's line says it is Streamline's general support check. - Comments and settings texts that still described the old behaviour: the process commit bound, the wait with shadow storage, the scratch's least size, the action prompt under auto. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> (cherry picked from commit 19f03aa01b26d6e17fb5fc70ad987aa8c68e8225)
This commit is contained in:
@@ -658,6 +658,15 @@ void mem_kernel_access(uint64_t a, uint64_t n) {
|
||||
plat_mutex_unlock(&frz_lock);
|
||||
}
|
||||
|
||||
// For a host scan of guest memory (camera_speed.c rewrite): the end of the run of pages at a that the lazy heap left
|
||||
// reserved, at most end, or 0 when the page at a is not such a page. Nothing was ever written there, so a scan steps
|
||||
// over the run; reading it would commit every page of the heap and undo what the setting saves.
|
||||
uint64_t mem_untouched_run(uint64_t a, uint64_t end) {
|
||||
if (!heap_lazy || a < L.heap.base || a >= L.heap.base + L.heap.size) return 0;
|
||||
uint64_t y, x = a & ~(PAGE - 1);
|
||||
return plat_mem_state(x, end, &y) == PLAT_MEM_RESERVED && y > a ? y : 0;
|
||||
}
|
||||
|
||||
// plat_mem_readable for a pointer the host is about to read: untouched heap pages of a lazy heap count as readable
|
||||
// (they are committed here, and read zero as they would have).
|
||||
int mem_host_readable(uint64_t a, uint64_t n) {
|
||||
@@ -1417,9 +1426,6 @@ void mem_kernel_free(void *p, uint64_t size) {
|
||||
plat_mutex_unlock(&klock);
|
||||
}
|
||||
|
||||
// NX2NAVI_TRACE=perf: how many bytes of each guest region are committed, so a process that has grown says which region
|
||||
// holds the memory. A region is reserved whole at start-up and committed page by page, so the walk reads each run of
|
||||
// pages of the same state; the alias window is the largest and costs the most steps when it is full.
|
||||
// NX2NAVI_TRACE=perf: what the lazy heap's first-use faults cost since the last line (perf.c, every perf window that had
|
||||
// some), so that a hitch can be told from them: the time includes the wait for frz_lock.
|
||||
void mem_lazy_heap_report(uint64_t frame) {
|
||||
@@ -1437,6 +1443,9 @@ void mem_lazy_heap_report(uint64_t frame) {
|
||||
faults_prv = faults, bytes_prv = bytes;
|
||||
}
|
||||
|
||||
// NX2NAVI_TRACE=perf: how many bytes of each guest region are committed, so a process that has grown says which region
|
||||
// holds the memory. A region is reserved whole at start-up and committed page by page, so the walk reads each run of
|
||||
// pages of the same state; the alias window is the largest and costs the most steps when it is full.
|
||||
void mem_guest_census(uint64_t frame) {
|
||||
const RtGuestLayout *g = mem_layout();
|
||||
const struct { const char *name; RtRange r; } reg[] = {
|
||||
|
||||
Reference in New Issue
Block a user