From 20a1410023014821a2d826b3f970cd4885eca9f3 Mon Sep 17 00:00:00 2001 From: bct8925 <31393107+bct8925@users.noreply.github.com> Date: Wed, 11 Nov 2026 19:33:18 -0500 Subject: [PATCH] Take a pass for DLSS's output only when it has the scene's shape. Ocarina redraws its 2000x2000 area map into an RGBA8 target of its own on a room change and on the pause menu: one colour target, no depth, larger than the scene both ways, which was all the output pass had to be. DLSS then wrote the game's picture into the map (the log's "DLSS feature created at 1280x720 -> 2000x2000"), and the minimap showed that picture behind its room shapes, a close-up of Navi or of Link from the moment of the room change, until the pause menu drew the map again. A pass whose width over height is more than 3% from the scene's is not the output; the first eight are logged. Co-Authored-By: Claude Opus 5.5 --- runtime/vk_dlaa.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/runtime/vk_dlaa.c b/runtime/vk_dlaa.c index 3854faab..489ece3d 100644 --- a/runtime/vk_dlaa.c +++ b/runtime/vk_dlaa.c @@ -488,6 +488,7 @@ static struct { int failed, reset; uint64_t evals, frames_missed; int share_off; // frames left that pick the output pass without the mode's share (vk_dlaa_pass, vk_dlaa_frame) + int shape_logged; // passes of another shape than the scene's turned down as the output pass (vk_dlaa_pass) // jitter (vk_dlaa_viewport) VkImage jdepth; // the scene depth of the last frame DLAA ran on: passes drawing with it are jittered uint32_t jw, jh; // its size: on Ocarina's frame the camera's draws into any D32F depth of it are (jitter_draw) @@ -2109,7 +2110,18 @@ void vk_dlaa_pass(VkExec *ex) { int native = share <= 0 || share >= 1; // no upscaling share: the scene is as large as the picture int big = D.share_off || native || c->width >= 0.95 * D.color.width / share; int same = c->width == D.color.width && c->height == D.color.height; - if (one && big && c->width > D.color.width && c->height > D.color.height) { + // The output pass has the scene's shape: the game redraws its 2000x2000 area map into an RGBA8 target of its + // own on a room change and on the pause menu, one colour target and no depth, larger than the scene both ways. + // Taken for the output pass, DLSS wrote the game's picture into the map, and the minimap showed that picture + // behind its room shapes until the pause menu drew the map again. A pass whose width over height is more than + // 3% from the scene's (sizes round to multiples of 8) is not the output; the ultrawide sets widen the scene + // with the picture, so their output pass still matches. + int shape = (double)c->width * D.color.height <= 1.03 * (double)c->height * D.color.width && + (double)c->height * D.color.width <= 1.03 * (double)c->width * D.color.height; + if (one && !shape && big && c->width > D.color.width && c->height > D.color.height && D.shape_logged < 8) + D.shape_logged++, rt_log("dlaa: a %ux%u pass is not the output pass: its shape is not the scene's %ux%u", + c->width, c->height, D.color.width, D.color.height); + if (one && shape && big && c->width > D.color.width && c->height > D.color.height) { // DLSS runs: the replay workers' draws read the jitter and its end, and list the per-object motion it // takes (vk_exec.c "replay workers"); the G-buffer and the arming above change nothing they read vk_exec_hook_turn();