mirror of
https://github.com/tangerineturtle1/NX2navi.git
synced 2026-11-19 21:39:58 -04:00
Give up on RivaTuner Statistics Server for the run when it hooks the game with the limit for 30 s and never shows it holds it.
The review found that nothing ended an RTSS hold that was never proven: when RTSS listed the game with the limit in its profile but one sign never came (presents of another API value than Vulkan's, the update flag never cleared, a period that never moved), the profile kept the limit and the game's pacer held the frames too for the whole run, two limiters where the pacing rules allow one, with only a reason line in the log and nothing in the menu. Before the hold had to be proven, RTSS alone held the game once it listed it. rtss_decide.h rtss_decide now counts the polls in a row where RTSS lists the game, the profile holds a limit of this run (not "none"), a picture went out within 200 ms and the hold is not shown; at RTSS_UNPROVEN_POLLS (60, 30 s) it puts the profile back and RTSS is out for the run (RTSS_FAIL_UNPROVEN, "RivaTuner Statistics Server never showed it holds the game"). A minimised window, RTSS not hooked, a want of no limit, a kept-out want or a poll that shows the hold start the count again. rtss_limit.c logs the give-up, rtss_limit_state returns 3 for it, so the menu says RivaTuner does not limit the game and the game does, and rtss_out_of_limit counts it, so a limit set in RTSS itself is reported as a second limiter. The comment above rtss_decide, rewritten for the rule, is wrapped at 120 columns and no longer cites rtss_fresh, which does not exist. tests/rtss_limit_check.c checks each sign that never comes (given up at the 60th poll, once, for the run), the polls that do not count and a shown hold restarting the count; tests/rtss_worker_check.c unproven_run checks it against the real worker. docs/architecture.md, docs/building.md and nx2navi.ini.example describe the rule and the remaining window of two limiters before it. This changes when the game takes the limit back from RTSS, beyond the approved rules: an RTSS whose hold never shows in its shared memory (a version or setting that differs) is now left out after 30 s and the game's limiter holds alone, as with rtss = 0, where it held the frames beside the game's limiter before. Not reproduced before the change. Checks that passed: tests/rtss_limit_check.py (41 of 41), pass_cc_check.py --wall on rtss_limit.c, tools/check_content.py --staged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -488,8 +488,9 @@ memory against a fake `RTSSSharedMemoryV2` (a bad header, short entries, an entr
|
||||
find nothing; the flags and the period where RTSS keeps them) and the worker's decisions poll by poll against a fake
|
||||
profile and a fake RTSS clock: RTSS's injection delay through listed with no API, the profile not read yet and no
|
||||
period measured, RTSS quitting and coming back, a read-only profile, a refused limit, the frame count rule (1.05 times
|
||||
the limit over three new periods, a frozen period never counted), no picture going out, kept-out wants and their
|
||||
reasons, a want that must stay two polls and low latency switching at every poll, a movie at 144 and at 40, a closed
|
||||
the limit over three new periods, a frozen period never counted), an RTSS that lists the game and never shows its
|
||||
hold (given up after 30 s, a minimised window not counted), no picture going out, kept-out wants and their
|
||||
reasons, a want that must stay two polls and low latency switching at every poll, a movie at 144, 60 and 40, a closed
|
||||
run, a hooks library that does not load, and two limiters. It also checks the pacer's period beside RTSS
|
||||
(`rtss_pace_period`), the limit's rounding without a denominator, and the state file `rtss-profile.txt`: its lines,
|
||||
its rewrite and what a start does with a line a run that did not close left. Statically, a crash and a fatal error
|
||||
|
||||
Reference in New Issue
Block a user